Jump to content
Sign in to follow this  
MartinPacker

firefox (Archived) Firefox Webclipper not working - broken javascript

Recommended Posts

Am using Evernote 4.0.0.106602 on Firefox (actually Mozilla/5.0 (X11; Linux i686; rv:2.0b8pre) Gecko/20101126 Firefox/4.0b8pre).

Webclipper is failing. Now, you might say the above Firefox level is unsupported. Fair enough but the Firefox Error Consols suggests the problem isn't with Firefox:

Error: conten is not defined

Source File: chrome://webclipper3-common/content/libs/evernote/overlay.js

Line: 27

In lines 26 to 28 we have:

if (typeof content.console != 'undefined') {

console = conten.console;

} else {

which COULD be corruption of the extension but looks like a typo.

I'm also not sure the test in line 26 is the compactest. :-)

Someone please corroborate / investigate.

Thanks, Martin

Share this post


Link to post

Thanks, Dave!

Looking at the code a tiny bit more I suspect this path is only encountered when something has ALREADY gone wrong, necessitating writes to the console. But obviously you'd still want that to work.

Share this post


Link to post

I had a bit of a play.

I fixed the typo you mentioned above and it wrote the error message to the error console.

Issue appears to be in WinMozillaNativeClipperImpl.js.

I put try error trapping around the method on line 22 as the line highlighted below generates a exception and doesn't exit gracefully.

With this fix it falls back to the web clipper but it is a little bit better then using the bookmarklet.

Evernote.WinMozillaNativeClipperImpl.prototype.isSupported = function() {

// make sure Evernote is installed

try

{

var enClipper = Components.classes["@Evernote/WebClipper3;1"].createInstance(Components.interfaces.IWebClipper3);

if(enClipper == null) {

return false;

}

return enClipper.IsEvernoteInstalled();

}

catch

{

}

return false;

};

Share this post


Link to post
Guest
This topic is now closed to further replies.
Sign in to follow this  

×
×
  • Create New...