1 reply to this topic

[AndyDent]

I'm getting a crash after calling [[EvernoteSession sharedSession] logout] because isAuthenticated is drilling down into trying to retrieve credentials when I later check. When I say "later" I mean, even on a subsequent run of the program.

I think EvernoteSession::authenticationToken should be rewritten as:

- (NSString *)authenticationToken
{
if (self.credentials)
  return [self.credentials authenticationToken];
return nil;
}

In detail

EvernoteSession.m contains

- (void)logout
{
// remove all credentials from the store and keychain
[self.credentialStore clearAllCredentials];

// remove the store from user defaults
[self.credentialStore delete];
}


- (BOOL)isAuthenticated
{
return (self.authenticationToken != nil);
}

This on the face of it looked completely logical.

When I try to check isAuthenticated after my app has logged out, authenticationToken calls down to the credential store without checking if it exists:

- (NSString *)authenticationToken
{
return [[self credentials] authenticationToken];
}

- (ENCredentials *)credentials
{
	return [self.credentialStore credentialsForHost:self.host];
}

and ends up throwing an exception from
EDAMUserStoreClient getUser: (NSString *) authenticationToken

GetUser_result(success:(null),userException:EDAMUserException(errorCode:5,parameter:"authenticationToken"),systemException:(null))

[SethH]

Hi Andy, sorry for the slow response on this. I don't think that the problem is coming from the SDK - the credential store doesn't make a call to UserStore.getUser. To try to reproduce this, I modified our sample app's iPhoneViewController logout method to make a call to isAuthenticated:

- (IBAction)logout:(id)sender {
    [[EvernoteSession sharedSession] logout];
    [self updateButtonsForAuthentication];
    if ([[EvernoteSession sharedSession] isAuthenticated]) {
        NSLog(@"isAuthenticated after logout");
    }
}

If the call to isAuthenticated caused the crash, then I'd expect the app to crash here, which it doesn't, nor is the NSLog message written - isAuthenticated returns false.